chore: remove support for long-deprecated 'edge' feature #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2022/2023 there was a customer project that required features in which certain internal notecard events would generate a queue of data that could later be polled. This feature ended up not being used by the customer. Later, the card.aux.serial 'notify' feature achieved most of the same requirements. Given that these features no longer exist within the notecard itself, the definitions related to this nonexistent feature have been removed from note-c.
haydenroche5
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2022/2023 there was a customer project that required features in which certain internal notecard events would generate a queue of data that could later be polled.
This feature ended up not being used by the customer. Later, the card.aux.serial 'notify' feature achieved most of the same requirements.
Given that these features no longer exist within the notecard itself, the definitions related to this nonexistent feature have been removed from note-c.