Make some tweaks to HIL testing. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't put the MD5 server URL in the log output. We want to keep that private. - Dynamically computed binary store size based on the MCU being used by the Notecard (i.e. r5 vs. u5). - Change timeout in waitForNotecardConnected to 5 minutes instead of 300 ms, which I believe was a mistake.
haydenroche5
force-pushed
the
hil_tweaks
branch
2 times, most recently
from
a98f3c7
to
b7722bb
Compare
zfields
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notecard (i.e. r5 vs. u5).
which I believe was a mistake.