Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add : Device manager integrations (RestAPI and Websocket) #4

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Add : Device manager integrations (RestAPI and Websocket) #4

merged 4 commits into from
Jul 29, 2024

Conversation

RaulTrombin
Copy link
Member

@RaulTrombin RaulTrombin commented Jul 12, 2024 •
edited
Loading

@RaulTrombin RaulTrombin marked this pull request as draft July 12, 2024 01:15
@RaulTrombin RaulTrombin force-pushed the add_integrations branch 3 times, most recently from e7819f1 to f999106 Compare July 18, 2024 14:35
@RaulTrombin RaulTrombin force-pushed the add_integrations branch 4 times, most recently from 2eba6f0 to f7de21d Compare July 20, 2024 01:22
@RaulTrombin RaulTrombin marked this pull request as ready for review July 25, 2024 01:20
@RaulTrombin RaulTrombin force-pushed the add_integrations branch 2 times, most recently from b4ae439 to 6f6f8b1 Compare July 25, 2024 19:03
@RaulTrombin RaulTrombin changed the title Add : Device manager integrations (RestAPI and Websocket) [WIP] Add : Device manager integrations (RestAPI and Websocket) Jul 29, 2024
patrickelectric
patrickelectric requested changes Jul 29, 2024
View reviewed changes
src/server/protocols/v1/websocket.rs Outdated
.then(|res, _, ctx| {
match &res {
Ok(result) => {
// ctx.text(serde_json::to_string_pretty(err).unwrap());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove lost code

src/server/protocols/v1/websocket.rs Outdated
}
Err(err) => {
ctx.text(serde_json::to_string_pretty(err).unwrap());
// crate::server::protocols::v1::websocket::send_to_websockets(json!(err), None);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove lost code

@RaulTrombin
Copy link
Member Author

ping @joaoantoniocardoso @patrickelectric

@patrickelectric patrickelectric merged commit a2bfa82 into bluerobotics:master Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaulTrombin @patrickelectric