Add: Dekstop-app #21
Add: Dekstop-app #21
Conversation
RaulTrombin
commented
Sep 11, 2024
•
RaulTrombin
commented
RaulTrombin
force-pushed
the
tauri-app
branch
2 times, most recently
from
cfebf45 to
6b066f4
Compare
RaulTrombin
force-pushed
the
tauri-app
branch
2 times, most recently
from
2a6416c to
fd99d3c
Compare
RaulTrombin
force-pushed
the
tauri-app
branch
from
fd99d3c to
d6228eb
Compare
RaulTrombin
force-pushed
the
tauri-app
branch
from
d6228eb to
a6b2593
Compare
.github/workflows/action.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - platform: 'macos-latest' # for Arm based macs (M1 and above). |
There was a problem hiding this comment.
Keep in mind that macos-13 is for Intel and macos-14/macos-latest is for ARM.
There was a problem hiding this comment.
bellow there is the args prop, i think the tauri-action is cross-compiling inside
- platform: 'macos-latest' # for Arm based macs (M1 and above).
args: '--target aarch64-apple-darwin'
- platform: 'macos-latest' # for Intel based macs.
args: '--target x86_64-apple-darwin'
336376f to
17e48a8
Compare
.github/workflows/action.yml
Outdated
| - uses: tauri-apps/[email protected] | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| projectPath: './ping-viewer-next-desktop' | ||
| tagName: app-v__VERSION__ # the action automatically replaces \_\_VERSION\_\_ with the app version. | ||
| releaseName: 'App v__VERSION__' | ||
| releaseBody: 'See the assets to download this version and install.' | ||
| releaseDraft: true | ||
| prerelease: false | ||
| args: ${{ matrix.args }} |
There was a problem hiding this comment.
We should avoid doing the release using the tauri action, and use it just for the build.
The action also does not provide artifacts, the best way of doing this is to use further steps to deploy artifacts and release files.
.github/workflows/action.yml
Outdated
| include: | ||
| - platform: 'macos-latest' | ||
| args: '--target aarch64-apple-darwin' | ||
| label: 'Mac-M1' |
There was a problem hiding this comment.
This should be Apple Silicon
| @@ -0,0 +1,24 @@ | |||
| # Logs | |||
There was a problem hiding this comment.
This is not necessary, can we clean it up ?
There was a problem hiding this comment.
this is the Logs default folder when we execute the desktop app with logger module with cargo run, would suggest to keep it
There was a problem hiding this comment.
I'm just saying to remove the unnecessary stuff, .idea, .dist-ssr, .sln
| name = "ping-viewer-next-desktop" | ||
| version = "0.1.0" | ||
| description = "A Tauri App" | ||
| authors = ["you"] |
.github/workflows/action.yml
Outdated
| with: | ||
| name: 'ping-viewer_${{steps.tauri-build.outputs.appVersion}}_${{ matrix.label }}' | ||
| path: "${{ join(fromJSON(steps.tauri-build.outputs.artifactPaths), '\n') }}" | ||
| retention-days: 5 |
