Update frontend data #66

joaoantoniocardoso · 2024-10-22T23:34:03Z

reworked_ui_with_stats.mp4

Closes #50

src/lib/web/mod.rs

src/webpage/src/stats/mod.rs

.gitignore

src/lib/web/endpoints.rs

src/lib/stats/actor.rs

patrickelectric · 2024-11-06T21:22:30Z

src/webpage/src/stats/mod.rs

+}
+
+#[derive(Debug, Clone, Default, Deserialize)]
+pub struct ByteStatsSample {


Why not getting it from the lib ?

It was the original plan, but the Implementations fail to compile for wasm32, and the change to organize the lib to make that easy is quite massive... I can do that if we prefer.

The first option is to pollute all lib/stats code with #[cfg(not(target_arch = "wasm32"))] switch flags, which makes the code very annoying.

The second option is to break the code into smaller modules: (1) mods that have the types, and (2) mods that have the implementation. These last are then selected with the switch flags, polluting only the imports. The mods can be all in separate files, or mod contexts.

Let me know if you have other ideas, and what you prefer

src/webpage/src/stats/stats_frequency.rs

src/webpage/src/app.rs

This helps some IDEs/LSPs configs to build the correct version on save

…dule

joaoantoniocardoso requested a review from patrickelectric October 22, 2024 23:34

joaoantoniocardoso force-pushed the update_frontend_data branch 4 times, most recently from 02cb4ac to 945a560 Compare October 29, 2024 15:46

patrickelectric requested changes Oct 29, 2024

View reviewed changes

src/lib/web/mod.rs Show resolved Hide resolved

src/webpage/src/stats/mod.rs Outdated Show resolved Hide resolved

joaoantoniocardoso force-pushed the update_frontend_data branch 6 times, most recently from 608d7e7 to 13af843 Compare November 4, 2024 23:33

joaoantoniocardoso requested a review from patrickelectric November 4, 2024 23:39

joaoantoniocardoso marked this pull request as ready for review November 4, 2024 23:39

joaoantoniocardoso force-pushed the update_frontend_data branch from 13af843 to 1554612 Compare November 5, 2024 13:33

patrickelectric requested changes Nov 6, 2024

View reviewed changes

joaoantoniocardoso force-pushed the update_frontend_data branch 2 times, most recently from f5e0477 to 3fe2b19 Compare November 8, 2024 18:24

joaoantoniocardoso added 12 commits November 8, 2024 15:25

src: lib: stats: Rework period internal API

36dede6

src: lib: web: Add stats stream internal API

e5b4fea

src: lib: web: Add stats frequency external API

8365a56

src: lib: web: Rename Drivers Stats external API

4ce4be8

src: lib: web: Add stats stream external API

011416f

src: lib: stats: underline unused property

35084f7

src: lib: stats: Fix redundant field initialization

b6841ee

src: lib: web: Remove unused imports

9cdf85e

src: lib: web: remove redundant async syntax

e3ae23f

src: lib: web: instrument websocket_handler

0d7534a

src: lib: web: Don't delay on startup

383090b

cargo: Update cargo lock file

a787bbb

joaoantoniocardoso added 14 commits November 8, 2024 15:26

src: webpage: cargo: Update ewebsock crate

a6aad10

src: webpage: cargo: Update tokio_with_wasm crate

4c6040a

src: webpage: cargo: Add indexmap, ehttp, ringbuffer, uuid crates

37310c0

src: webpage: cargo: Update cargo lock file

8370f2a

src: webpage: .cargo: Add cargo config for wasm32 project

49c961b

This helps some IDEs/LSPs configs to build the correct version on save

src: webpage: src: Add stats mod, move vehicle messages to its own mo…

6750f11

…dule

src: webpage: src: Move from new to default

852c0c0

src: webpage: src: Refactor connection/reconnection

e562d11

src: webpage: src: Refactor message and hub message stats receiving

85ef84a

src: webpage: src: Refactor message and hub message UI

d69d29f

src: webpage: src: Add Hub Stats

ecbd0c4

src: webpage: src: Add Drivers Stats

9395934

src: webpage: src: Add frequency control

39bea78

src: webpage: src: Refactor the App UI

6b1e9aa

joaoantoniocardoso force-pushed the update_frontend_data branch from 3fe2b19 to 6b1e9aa Compare November 8, 2024 18:27

patrickelectric approved these changes Nov 8, 2024

View reviewed changes

patrickelectric merged commit 6051127 into bluerobotics:master Nov 8, 2024
8 checks passed

joaoantoniocardoso deleted the update_frontend_data branch November 8, 2024 19:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update frontend data #66

Update frontend data #66

joaoantoniocardoso commented Oct 22, 2024 •

edited

Loading

patrickelectric Nov 6, 2024

joaoantoniocardoso Nov 7, 2024 •

edited

Loading

Update frontend data #66

Update frontend data #66

Conversation

joaoantoniocardoso commented Oct 22, 2024 • edited Loading

patrickelectric Nov 6, 2024

Choose a reason for hiding this comment

joaoantoniocardoso Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

joaoantoniocardoso commented Oct 22, 2024 •

edited

Loading

joaoantoniocardoso Nov 7, 2024 •

edited

Loading