Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix receiving #5

Merged
merged 24 commits into from
Sep 2, 2024

Conversation

joaoantoniocardoso
Copy link
Member

No description provided.

@joaoantoniocardoso joaoantoniocardoso force-pushed the fix_receiving branch 7 times, most recently from f4efe33 to 7cbb143 Compare September 1, 2024 00:56
@joaoantoniocardoso joaoantoniocardoso marked this pull request as ready for review September 1, 2024 01:00
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor points

src/drivers/udp/server.rs Outdated Show resolved Hide resolved
src/drivers/udp/server.rs Outdated Show resolved Hide resolved
src/drivers/file/server.rs Show resolved Hide resolved
async move { driver.run(sender).await }
});

// let file_v1_messages = 2; // TODO: Add support for V1 messages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How v1 exist in the same log file is a mystery

Copy link
Member Author

@joaoantoniocardoso joaoantoniocardoso Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are the first two messages in the tlog file:

2024-04-22 18:49:08.00: HEARTBEAT {type : 12, autopilot : 3, base_mode : 81, custom_mode : 19, system_status : 5, mavlink_version : 3}
2024-04-22 18:49:08.12: HEARTBEAT {type : 12, autopilot : 3, base_mode : 81, custom_mode : 19, system_status : 5, mavlink_version : 3}

src/drivers/file/server.rs Show resolved Hide resolved
@patrickelectric patrickelectric merged commit c969e6a into bluerobotics:master Sep 2, 2024
8 checks passed
@joaoantoniocardoso joaoantoniocardoso deleted the fix_receiving branch September 2, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants