Add hub stats #19
Merged
Add hub stats #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaoantoniocardoso
force-pushed
the
add_stats
branch
from
a2537ac to
692aa43
Compare
joaoantoniocardoso
force-pushed
the
add_stats
branch
from
692aa43 to
baa7c36
Compare
patrickelectric
requested changes
Sep 16, 2024
| @@ -47,6 +49,23 @@ impl StatsActor { | |||
| } | |||
| }); | |||
|
|
|||
| let hub_stats_task = tokio::spawn({ | |||
| let hub = self.hub.clone(); | |||
| let update_period = Arc::clone(&self.update_period); | |||
There was a problem hiding this comment.
is there a reason for not calling clone directly ?
There was a problem hiding this comment.
there is no difference, that's a more expressive way of saying you are cloning the ARC, not the data, but we can use .clone, no worries!
There was a problem hiding this comment.
... or just let's use it 😆
joaoantoniocardoso
force-pushed
the
add_stats
branch
from
baa7c36 to
1e8f825
Compare
patrickelectric
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the same metrics from drivers for the hub.