-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new main menu and responsivity logic #985
Implement new main menu and responsivity logic #985
Conversation
Signed-off-by: Arturo Manzoli <[email protected]>
This looks nice! Will start the reviewing right up on! |
093455d
to
f0d50be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When clicking the button with the menu open, it's reopening, instead of closing:
Kapture.2024-06-05.at.14.33.15.mp4
The configuration menus are not opening:
Kapture.2024-06-05.at.14.35.16.mp4
I also feel like there should be some transition in the opening/closing of this side menu. It's just appearing and disappearing as of now.
393f33c
to
eb7dd93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
eb7dd93
to
ed196e4
Compare
The misalignment of the icons wasn't present on the browser used during development. It is probably Mac-related. Anyway, I refactored the centering logic, and it should now be centered on all Chrome browsers. Please retest it. Regarding the configuration menu items not being clickable, this is normal for now. Only the menu has been implemented so far. The configuration screens are being implemented in different tasks. |
Got it! |
Running on different device screen resolutions:
Closes #968