video: Warn user if they selected an IP that is not available in the ICE candidates #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
requested review from
ArturoManzoli,
JoaoMario109 and
patrickelectric
rafaellehmkuhl
force-pushed
the
ice-ip-not-available
branch
from
8e32da8 to
a81584c
Compare
I got into several situations were BlueOS was not able to answer in the former 5 seconds.
rafaellehmkuhl
force-pushed
the
ice-ip-not-available
branch
from
a81584c to
e137d54
Compare
patrickelectric
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This situation leads to the ICE negotiation failing (since we are not allowing any of the available IPs), and thus no video stream being loaded.
For the future, we should change all those SweetAlerts by our own library, probably using the
InteractionDialogcomponent. This is probably part of #875.Fix #661.