sensors-logging: Find log by day prioritizing those from the last day #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
requested review from
patrickelectric,
ArturoManzoli and
JoaoMario109
rafaellehmkuhl
changed the title
ArturoManzoli
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry logs are taking a lot of time to be processed, and looking more into it, I realized it is because we are accessing each log file individually and checking if it matches our criteria.
This patch fixes it with a quick and dirty solution: iterating first over the logs from the day of the video and the day before, and only them on the rest of the logs (which would be the case only for videos being recorded for more than 24 horus...).
The best solution would be to index the DB by timestamp, sort it and check the logs starting from the most recent one, with a proper cursor, but it is a more complex solution that I need to study more about, while the one here solves the problem already.
Fix #908