Adding Slider to Adjust Altitude

[ericjohnson97]

closes #580

This slider component is designed to be similar to the slider in QGC for adjusting altitude. It is shown when an altitude change is commanded and is set when the user "slides to confirm"

2024-02-04.18-28-24.mp4

[rafaellehmkuhl]

Pretty cool!
Could you add an alert (on the alert system) for when the command is accepted? It would be a good feedback for the user to know it worked (besides actually looking at the altitude, of course).

[ericjohnson97]

@rafaellehmkuhl I didn't know that if I left a comment on a line of code it was not publicly viewable until I hit "submit review". I had made those comments last night, and didn't realize my mistake until now.

[ericjohnson97]

Pretty cool! Could you add an alert (on the alert system) for when the command is accepted? It would be a good feedback for the user to know it worked (besides actually looking at the altitude, of course).

I think that could be a good addition. Do you think it would be best done based on the command accepted ack message? If so, then we could implement that as a generic alert as we had talked about in the past. similar to this #628 but for accepted.

Otherwise I could make an alert when the command is executed. Or I could make a special case to listen for the ack, but without the ack confirmation I won't truly know if it has been accepted.

[rafaellehmkuhl]

Pretty cool! Could you add an alert (on the alert system) for when the command is accepted? It would be a good feedback for the user to know it worked (besides actually looking at the altitude, of course).

I think that could be a good addition. Do you think it would be best done based on the command accepted ack message? If so, then we could implement that as a generic alert as we had talked about in the past. similar to this #628 but for accepted.

Otherwise I could make an alert when the command is executed. Or I could make a special case to listen for the ack, but without the ack confirmation I won't truly know if it has been accepted.

You're right. Let's leave that for a separated PR.

[rafaellehmkuhl]

@ericjohnson97 before opening the PR for review, could you rewrite the commits to follow more or less the current pattern on the repository commits (e.g.: letter case, way of writing, etc).

[ericjohnson97]

@ericjohnson97 before opening the PR for review, could you rewrite the commits to follow more or less the current pattern on the repository commits (e.g.: letter case, way of writing, etc).

Of course. I wanted to make sure you were OK with the general implementation before I cleaned up my developmental commits.

[rafaellehmkuhl]

This looks good to me! Can we merge it @ericjohnson97?

[ericjohnson97]

This looks good to me! Can we merge it @ericjohnson97?

It should be good to go!