stores: alert: Use platform language by default over default speech #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patrickelectric
requested review from
Williangalvani,
rafaellehmkuhl and
joaoantoniocardoso
patrickelectric
force-pushed
the
set-default-language
branch
from
722a8b2 to
3771933
Compare
Usually the speech language should be the same as the platform language, but it appears that some browsers have a weird default speech language. To be safer, we use by default the current platform language, and if that does not exist, the default speech language. Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
set-default-language
branch
from
3771933 to
2682d20
Compare
rafaellehmkuhl
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually the speech language should be the same as the platform language, but it appears that some browsers have a weird default speech language. To be safer, we use by default the current platform language, and if that does not exist, the default speech language.