Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change colors in switch components when toggled #675

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Change colors in switch components when toggled #675

merged 2 commits into from
Jan 5, 2024

Conversation

wandersonsousa
Copy link
Contributor

@wandersonsousa wandersonsousa commented Jan 5, 2024

Close some tasks from #673

Interface visibility/intuition improvements

  • alert config
    colors_to_switchs
  • armed/disarmed slider
    armed
    disarmed
    undefined

@wandersonsousa
Copy link
Contributor Author

I see now that the config alerts switchs are inverted, should be Armed = Red and Disamerd = Green, right?

@rafaellehmkuhl
Copy link
Member

rafaellehmkuhl commented Jan 5, 2024

Nice seeing the additions @wandersonsousa!

Yes, it should be the opposite.

I also think we should change the color of the background instead of the letters. Maybe @rjehangir or @ES-Alexander have some suggestion on that.

As it's one of the main components, I would like to see some discussion around its design before doing this kind of change.

@rjehangir
Copy link
Member

Nice! I like the addition of colors. For the arm/disarm, I agree it would be interesting to set the background color instead of the text color so that it is much more obvious. The arm/disarm in Cockpit has always been a little subtle.

@wandersonsousa
Copy link
Contributor Author

Great, I'll come back soon as I can with updates.

@patrickelectric patrickelectric merged commit 83e744f into bluerobotics:master Jan 5, 2024
8 checks passed
@patrickelectric
Copy link
Member

Oppps, sorry, I went directly on the code to do the review and missed the discussion.

@wandersonsousa
Copy link
Contributor Author

Oppps, sorry, I went directly on the code to do the review and missed the discussion.

Well, It's not breaking anything, as its are little changes. Maybe I can update it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants