Multi joystick functions profile #667
Conversation
rafaellehmkuhl
force-pushed
the
multi-joystick-functions-profile
branch
from
0af36ea to
dd4fb5f
Compare
rafaellehmkuhl
force-pushed
the
multi-joystick-functions-profile
branch
2 times, most recently
from
782d59f to
27e8039
Compare
| <Button | ||
| v-for="functionMapping in controllerStore.protocolMappings" | ||
| :key="functionMapping.name" | ||
| class="m-2" | ||
| :class="{ 'bg-slate-700': controllerStore.protocolMapping.name === functionMapping.name }" | ||
| @click="controllerStore.loadProtocolMapping(functionMapping)" | ||
| > | ||
| {{ functionMapping.name }} | ||
| </Button> |
There was a problem hiding this comment.
I think the buttons would be more intuitive if they said something like "Restore default ROV controls" - general users don't need to know that we're calling them "functions mappings" internally, and the active "Restore" makes it clearer that the current mapping is going to be replaced by a different one, as opposed to the similarly styled modifier buttons directly below which just display different parts of the current controls mapping.
Tangentially related, having buttons for this that look the same as the buttons for the modified profiles (regular/shift) is unintuitive and somewhat unpleasant. That's probably out of scope for this PR though, since the preferred improvement is to change the modified profiles buttons into tabs (like in #617), and the new restore functions can be left as buttons.
There was a problem hiding this comment.
Agree with almost everything. The restore I'm not sure about as this is actually not a "restore" button, but a switch between mappings. I agree thought that it is currently very non-intuitive. I want to change this whole interface once we get the needed functionalities on (I think we are only missing the 32 buttons support after this PR).
There was a problem hiding this comment.
this is not actually a "restore" button, but a switch between mappings
That doesn't make sense to me - if it's changing the mappings to a default one (not determined by the user) then I would call that restoring (from their current customised one). If it's just two separate vehicle-type-specific profiles that the user has independent control over then we shouldn't have "default" in the button names.
There was a problem hiding this comment.
They are determined by the user when he changes it. They have default in the name because they start as default, but I agree with you on this. Will remove the "default" from the name.
rafaellehmkuhl
force-pushed
the
multi-joystick-functions-profile
branch
from
27e8039 to
8a5c6d2
Compare
rafaellehmkuhl
force-pushed
the
multi-joystick-functions-profile
branch
from
8a5c6d2 to
dd31d01
Compare
rafaellehmkuhl
force-pushed
the
multi-joystick-functions-profile
branch
from
dd31d01 to
6440af4
Compare
rafaellehmkuhl
force-pushed
the
multi-joystick-functions-profile
branch
from
6440af4 to
d4ebd40
Compare
rafaellehmkuhl
force-pushed
the
multi-joystick-functions-profile
branch
from
d4ebd40 to
50cd28d
Compare
rafaellehmkuhl
force-pushed
the
multi-joystick-functions-profile
branch
from
50cd28d to
f84ecb4
Compare
I'm waiting for Tony or Kurt to confirm if the boat profile is correct (specially the Z axis mapping).Fixed with Tony's help.Fix #636.