Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generic indicator size #606

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Fix generic indicator size #606

merged 2 commits into from
Nov 28, 2023

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Nov 28, 2023 •
edited
Loading

This problem was happening for smaller screens.

Before:

Screenshot 2023-11-28 at 17 51 24

After:

Screenshot 2023-11-28 at 17 52 01

Fix #492

joaoantoniocardoso
joaoantoniocardoso approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested :)

@rafaellehmkuhl rafaellehmkuhl merged commit 02502ec into bluerobotics:master Nov 28, 2023
8 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the fix-generic-indicator-size branch November 28, 2023 21:42
@rafaellehmkuhl rafaellehmkuhl mentioned this pull request Nov 29, 2023
Closed
@ocean-engineer ocean-engineer mentioned this pull request Sep 11, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

@rjehangir rjehangir Awaiting requested review from rjehangir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VeryGenericIndicator still changes its width
2 participants
@rafaellehmkuhl @joaoantoniocardoso