-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mode for Copter and Plane Vehicle Types #575
Update Mode for Copter and Plane Vehicle Types #575
Conversation
Hi @ericjohnson97! First of all, I want to thank you for your contribution. You're the first contributor of cockpit outside of our Blue Robotics team! I'm currently out of home but I will review your PR as soon as I can. |
@rafaellehmkuhl No rush on the review. I am just getting my feet wet with cockpit. I am really excited about this project and I want to use it with arducopter and arduplane in particular. I would love to help out in anyway I can with this project so let me know if there are any plane - copter features that I could focus on. |
@ericjohnson97 please check the errors pointed in CI, there are some problems pointed by the linter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eric, as you suggested in the issue, I think the correct approach would be to change the ardupilot.ts
file, as it's working for the Sub and Boat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Could you squash the commits before we merge?
I haven't done that before other than on merges. Is there not an option to merge and squash? |
Yes, I can squash all into one from GitHub itself. It's just that if you preferred to have them on more than one commit, it would have to be manually. |
This Merge Request to fix the mode selector not showing the current mode as described here
#574
Makes the mode be driven off of the custom_mode field in the heartbeat.