Improvements on the joystick pipeline #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
joystick-works
branch
3 times, most recently
from
161600b to
6a398a2
Compare
rafaellehmkuhl
force-pushed
the
joystick-works
branch
2 times, most recently
from
7437c30 to
df1507a
Compare
This way they are more generic, better considering joystick with not-so-traditional layouts.
Make it more in sync with the name for the axis variable.
…ocol function Allow two buttons to activate the same function, if the user wants that.
They are used as base interfaces for inheritance.
…hicle This is definitely not on the correct place as it's ArduPilot specific. It should be moved together with the moving of the ardupilot-parameters related code that is on the main vehicle store, through an abstraction.
… on the vehicle When the function is not mapped, try to map it.
rafaellehmkuhl
force-pushed
the
joystick-works
branch
from
df1507a to
eba53dc
Compare
rafaellehmkuhl
changed the title
If one of them is undefined, it's not a real protocol input.
Nulled inputs are not undefined (not-defined), but null (defined as null). Also, `null` is not removed from arrays in JSON parsing, so it will not break local storage, for example.
… availableInputs array With this, all available inputs are created on the internal library, instead of the view component.
patrickelectric
approved these changes
Sep 7, 2023
12 tasks
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Dec 12, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Dec 12, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added
docs-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for tracking the improvements on the joystick that are being worked on right now.
The 3 main goals are:
Support modifier button on the joystick (shift button + button)Won't be done for nowSupport both ROV and BOAT control methods transparently (maybe by modifying the ROV firmware and just use the regular/boat way for any vehicle?)Won't be done for nowThe extra goal is to improve the current codebase, which has some messy and difficult-to-understand parts.
Fix #263
Fix #455
Fix #457
Fix #454