EditMenu: differentiate external widgets from Cockpit's own #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
requested review from
rafaellehmkuhl,
ArturoManzoli and
ES-Alexander
and removed request for
rafaellehmkuhl
rafaellehmkuhl
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Loved it, but will wait for @ArturoManzoli to give his thoughts.
Williangalvani
force-pushed
the
differentiate
branch
from
4eec0f4 to
f4d00a0
Compare
|
Updated: Waiting for SMS's seal of approval |
ES-Alexander
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if red is the best color here... thoughts?