Add independent component for side config panel #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoManzoli
force-pushed
the
add-component-for-side-config-panel
branch
from
2d4d6bd to
e69734c
Compare
rafaellehmkuhl
requested changes
Dec 16, 2024
Comment on lines
-620
to
+623
| <transition | ||
| enter-active-class="transition-transform duration-500 ease-in-out" | ||
| leave-active-class="transition-transform duration-0 ease-in-out" | ||
| enter-from-class="translate-x-full opacity-0" | ||
| enter-to-class="translate-x-0 opacity-100" | ||
| leave-from-class="translate-x-0 opacity-100" | ||
| leave-to-class="translate-x-full opacity-0" | ||
| > | ||
| <div | ||
| v-if="store.isElementsPropsDrawerVisible && store.editingMode && store.elementToShowOnDrawer" | ||
| class="flex fixed w-[250px] h-[78vh] right-0 top-0 border-l-[1px] border-[#FFFFFF44] text-white elevation-5 bg-[#051e2d]" | ||
| > | ||
| <ElementConfigPanel /> | ||
| </div> | ||
| </transition> | ||
|
|
||
| <SideConfigPanel position="right"> | ||
| <ElementConfigPanel v-if="store.elementToShowOnDrawer?.hash" /> | ||
| </SideConfigPanel> |
There was a problem hiding this comment.
Always nice to see this kind of cleaning happening in the code.
Can we also remove the styles and other parts not used anymore in this file?
| @@ -27,6 +27,7 @@ export const useAppInterfaceStore = defineStore('responsive', { | |||
| configComponent: -1, | |||
| isGlassModalAlwaysOnTop: false, | |||
| isTutorialVisible: false, | |||
| configPanelVisible: false, | |||
There was a problem hiding this comment.
This commit and the last one should be squashed. One does not function without the other.
| @@ -0,0 +1,531 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Were there code changes or was the only modification the change on the name of the file?
There was a problem hiding this comment.
There were code changes, indeed but hidden by the file rename process.
The files now is renamed on its EditMenu implementation commit
ArturoManzoli
force-pushed
the
add-component-for-side-config-panel
branch
from
e69734c to
b660812
Compare
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
force-pushed
the
add-component-for-side-config-panel
branch
from
b660812 to
0f63aa8
Compare
rafaellehmkuhl
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** As part of the "Extend survey to generic MAVLink commands" implementation