Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: PR Preview #1496

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

RaulTrombin
Copy link
Member

@RaulTrombin RaulTrombin commented Dec 9, 2024

Sets up a cockpit preview available directly on PR,
works with main deployment branch and automatically clean previews once they are merged/closed.
Details: https://github.com/rossjrw/pr-preview-action

@RaulTrombin
Copy link
Member Author

Looks like we cant't run safely from forks.
rossjrw/pr-preview-action#6

emilk/egui#5131

@rafaellehmkuhl
Copy link
Member

Looks like we cant't run safely from forks. rossjrw/pr-preview-action#6

emilk/egui#5131

So it wouldn't work with PR made from forks? Or it just wouldn't work in the fork repositories? The first is a problem, the second is not.

@RaulTrombin
Copy link
Member Author

Looks like we cant't run safely from forks. rossjrw/pr-preview-action#6
emilk/egui#5131

So it wouldn't work with PR made from forks? Or it just wouldn't work in the fork repositories? The first is a problem, the second is not.

Seems we can grant "write" permissions to the action, so any PR made will have preview,
but we need to be sure that in our org, we'll carefully check PR's content and aproove it to run. ( preferably for each org external fork PR, as it can create a bad html, read our org secrets and so on.)

The egui aproach created another organization just to handle previews, so they dont have the issue on their main repo/org permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants