Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new default boat profile #1419

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Add new default boat profile #1419

merged 2 commits into from
Nov 4, 2024

Conversation

ArturoManzoli
Copy link
Contributor

@ArturoManzoli ArturoManzoli commented Oct 21, 2024 •
edited
Loading

  • Added a new default profile for USVs;
  • Added 'Decimal places' and 'Display width' parameters on the Very Generic Indicator custom component creator; so, it would be possible to display the boat speed correctly on the profile;

image
image

Closes #592

rafaellehmkuhl
rafaellehmkuhl requested changes Oct 26, 2024
View reviewed changes
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in the VGI brakes all the existing VGIs

image

src/assets/defaults.ts Outdated
hash: defaultBoatProfileHash,
hash: 'adb7d856-f2e5-4980-aaeb-c39c1fa3562b',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change brakes the profile auto-load functionality.

@rafaellehmkuhl
Copy link
Member

For comparison, this is the bottom bar when I get out the branch:

image

@ArturoManzoli ArturoManzoli force-pushed the 592-New-default-boat-profile branch 2 times, most recently from da988e0 to ea00b25 Compare October 30, 2024 15:21
@ArturoManzoli
Copy link
Contributor Author

Last push:

  • Fixed VGI minimum width;
  • Fixed default.ts profile hash;

rafaellehmkuhl
rafaellehmkuhl requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's almost there!

One thing that is still not working: when increasing the width of an existing VGI, the extra space is not being used for the decimal places or the unit.

image

@ArturoManzoli ArturoManzoli force-pushed the 592-New-default-boat-profile branch from ea00b25 to ec1be82 Compare November 1, 2024 10:19
rafaellehmkuhl
rafaellehmkuhl requested changes Nov 4, 2024
View reviewed changes
src/components/EditMenu.vue Outdated
class="flex flex-row justify-start relative items-center bg-[#CBCBCB2A] elevation-5 2xl:h-full xl:h-[45px] h-[35px] overflow-hidden"
class="flex flex-row justify-start relative items-center bg-[#CBCBCB2A] elevation-5 2xl:h-[55px] xl:h-[45px] h-[35px] overflow-hidden"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not fixing the full-height problem.
We can just remove this commit as its not necessary to this PR, merge the PR and attack this problem on a later one.

image

Copy link
Contributor Author

@ArturoManzoli ArturoManzoli Nov 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not fixing the full-height problem. We can just remove this commit as its not necessary to this PR, merge the PR and attack this problem on a later one.

Removed :) !

@ArturoManzoli ArturoManzoli force-pushed the 592-New-default-boat-profile branch from ec1be82 to cbf7f78 Compare November 4, 2024 16:20
@rafaellehmkuhl rafaellehmkuhl merged commit 6db6ede into bluerobotics:master Nov 4, 2024
10 checks passed
@rafaellehmkuhl rafaellehmkuhl linked an issue Nov 4, 2024 that may be closed by this pull request
frontend: Add GPS default for widget and allow changing significant digits displayed #1326
Closed
1 task
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaellehmkuhl rafaellehmkuhl rafaellehmkuhl approved these changes

Assignees
No one assigned
Labels
docs-needed Change needs to be documented
Projects
None yet
Milestone
No milestone
3 participants
@ArturoManzoli @rafaellehmkuhl @ES-Alexander