-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-updating system [electron-only] #1396
Add auto-updating system [electron-only] #1396
Conversation
5d05377
to
3e735a9
Compare
3ebec9e
to
265a3e0
Compare
6c4c088
to
93c997d
Compare
93c997d
to
35c83a9
Compare
I'm trying to test with the mocks made, but can't get any update popup to show. I should just checkout 'auto-update-dev-test-changes' and run the electron app? |
Did you run a |
Yep, I did. Also tried from the electron AppImage executable, but it also didn't run the mocked update |
Strange. Just tested here without problems. Let me rebase the lockfile to see if that helps. |
It will be used for offering auto-updates of the Electron app.
With this new implementation, the user is informed that a new version of the application is available and can choose between downloading it or not.
35c83a9
to
af65830
Compare
@ArturoManzoli rebased. Can you try again? If it doesn't work, try removing node-modules and the bun lockfile, and run If it still doesn't run, can you check the console (both from the terminal and browser) to see what is going on? |
For notice: it may be that we can't make the auto-update system work on Linux, due to restrictions on how it works, and the feature will be mac/windows-only. I confirmed already that it is working on mac and @ArturoManzoli will test to see if it's working on Windows. There's a small chance we can make it work on Linux and this comment is maybe relevant. |
Tested and confirmed. It works very well on Windows |
This PR adds an auto-updating system to the electron version of Cockpit.
This system informs the user when new versions are available, allows the user to download and install it, ignore it for now or skip the given version.
With it, the users don't have to reach out to GitHub to check for new versions and download them anymore.
Kapture.2024-12-11.at.06.14.54.mp4
It works here by mocking the version, which means it will almost surely work once in production. To test it with the mocks, checkout this branch.
Fix #1290.