Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version-selector: add staleness indication #28

Merged

Conversation

ES-Alexander
Copy link
Collaborator

@ES-Alexander ES-Alexander commented Dec 13, 2024

Relevant to #23, although there's still room for improvement (e.g. with some explanatory text somewhere, instead of just colours).

Expects a versions .json file like:

[
    ["/docs/latest/", "Latest", "dev"], 
    ["/docs/stable/", "1.3 (stable)", "stable"], 
    ["/docs/1.2/", "1.2", "recent"], 
    ["/docs/1.1/", "1.1", "old"], 
    ["/docs/1.0/", "1.0", "archived"]
]

Might be worth consulting SMS on the colours 🤷‍♂️

Existing:

Screenshot 2024-12-13 at 4 52 06 pm

Version indicator after PR:

Screenshot 2024-12-13 at 11 46 53 pm Screenshot 2024-12-14 at 12 43 52 am Screenshot 2024-12-13 at 11 46 34 pm Screenshot 2024-12-13 at 11 46 29 pm Screenshot 2024-12-13 at 11 46 23 pm

@ES-Alexander ES-Alexander force-pushed the improve-version-selector-style branch 2 times, most recently from 27038bf to cb607ef Compare December 13, 2024 12:50
@ES-Alexander ES-Alexander force-pushed the improve-version-selector-style branch from cb607ef to 7930841 Compare December 13, 2024 13:44
@voorloopnul voorloopnul merged commit 0149d77 into bluerobotics:main Dec 13, 2024
@ES-Alexander ES-Alexander deleted the improve-version-selector-style branch December 13, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants