-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boot fix stage 2 #2537
base: master
Are you sure you want to change the base?
Boot fix stage 2 #2537
Conversation
@patrickelectric @joaoantoniocardoso this is what I had in mind for making sure our install scripts match our blueos_startup_update. I am open for suggestions and/or better alternatives. One thing I'm worried about is that our startup.json.default should always match what is actually in blueos. so I don't think it should be manipulated by blueos_startup_update during the first boot. |
this is the actual test part |
I think this idea works, as it contemplates the requirements for the config file:
I think the next thing we should do is to generate the file in the tree as a git pre-commit client-side hook that runs whenever the script changes. |
9e862da
to
a76dc72
Compare
34abbbc
to
b4ddc56
Compare
@joaoantoniocardoso @JoaoMario109 @patrickelectric how do you guys feel about this? |
This tests our install.sh scripts against blueos_startup_update to ensure the current code state will never require a subsequent reboot after blueos_startup_update