Scripts on Wizard #2487
Merged
Scripts on Wizard #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
depends on bluerobotics/Blueos-Parameter-Repository#6 |
Williangalvani
commented
Mar 25, 2024
Williangalvani
commented
Mar 25, 2024
patrickelectric
requested changes
Mar 26, 2024
| @@ -648,6 +667,34 @@ export default Vue.extend({ | |||
| }) | |||
| .catch((error) => `Failed to fetch available firmware: ${error.message ?? error.response?.data}.`) | |||
| }, | |||
| async installScripts(): Promise<ConfigurationStatus> { | |||
| const scripts_folder = 'configs/ardupilot-manager/firmware/scripts/' | |||
| await filebrowser.createFolder('') | |||
There was a problem hiding this comment.
what ? create a folder with empty name ?
There was a problem hiding this comment.
yep, this is wrong
There was a problem hiding this comment.
the upside is we found out we don't need to explicitly create the folder
| console.log(e) | ||
| return `Failed to install scripts ${e}` |
There was a problem hiding this comment.
Suggested change
| console.log(e) | |
| return `Failed to install scripts ${e}` | |
| const error = `Failed to install scripts ${e}` | |
| console.log(error) | |
| return error |
|
|
||
| import { availableFirmwares, fetchCurrentBoard } from '../autopilot/AutopilotManagerUpdater' | ||
|
|
||
| const REPOSITORY_ROOT = 'https://williangalvani.github.io/Blueos-Parameter-Repository_/' |
There was a problem hiding this comment.
can we remove the trailing / for the path strings to be clear as path strings ?
E.g:
const REPOSITORY_URL = `${REPOSITORY_ROOT}/scripts_v1.json`
// Over
const REPOSITORY_URL = `${REPOSITORY_ROOT}scripts_v1.json`
patrickelectric
approved these changes
Mar 26, 2024
|
@Williangalvani can you cherry-pick to 1.2 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs more testing, but looking good so far. I'll review it tomorrow