Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: BluezAgent: Use 5 digit pin for request_pin/passkey #2176

Closed
wants to merge 1 commit into from

Conversation

infirit
Copy link
Contributor

@infirit infirit commented Oct 23, 2023

Is there a reason why we don't make a pin for the user instead of having them type one in a dialog?

ps: completely untested

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@cschramm
Copy link
Member

That's just not how it works. Generally with legacy pairing or when one device has only input or only display capability, one side displays a code and the other side requests to enter that code. There are deviations, e.g. where a code is hardcoded and you have to enter that code on the other end.

I probably totally do not get the intention, but I'm not aware of a single case where the user may choose the requested code.

@infirit
Copy link
Contributor Author

infirit commented Oct 24, 2023

You're not missing anything. I was confused by discussion where blueberry apparently was showing a pin.

@infirit infirit closed this Oct 24, 2023
@infirit infirit deleted the agentmakepinonrequest branch October 24, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants