Listbox for plugindialog #2137
Merged
Listbox for plugindialog #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infirit
force-pushed
the
plugindialoglistbox
branch
3 times, most recently
from
154c0c3 to
cd34291
Compare
|
The weirdness was because I messed up gsettings. Cleaned it up and it's ready for review. Hopefully based of this I can do the same for the ManagerDeviceList to make it much easier to implement a new design. |
infirit
force-pushed
the
plugindialoglistbox
branch
from
cd34291 to
d3a18b3
Compare
infirit
force-pushed
the
plugindialoglistbox
branch
from
d3a18b3 to
3ffbbd2
Compare
cschramm
previously approved these changes
Oct 29, 2023
infirit
force-pushed
the
plugindialoglistbox
branch
from
3ffbbd2 to
bfa4bd5
Compare
cschramm
previously approved these changes
Nov 12, 2023
infirit
force-pushed
the
plugindialoglistbox
branch
from
bfa4bd5 to
6ae4ddf
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
cschramm
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still see some weirdness with enabling/disabling plugins but I suspect I messed up my gsettings in the process. Putting it out here as a possible option to use for blueman-manager's device list.
The idea here is that we make our own widget in the factory function and then optionally bind the GObject property to widgets. Then updating the
GObjectproperty will automatically update the UI. The plugin dialog is not very dynamic and used statefulSimpleActionfor the checkbox but binding the enabled property is also an option.mypy was very unhappy so some of the typing annotation looks weird and I had to cast the
PluginItemproperties to convince it.The other option is to use
ListBoxRowsand insert them manually into theListBox.