Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enum constructor clause #12

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix: Enum constructor clause #12

merged 2 commits into from
Oct 30, 2023

Conversation

bdlukaa
Copy link
Contributor

@bdlukaa bdlukaa commented Oct 15, 2023

Fixes #10

@bdlukaa bdlukaa changed the title fix: enum constructor clause fix: Enum constructor clause Oct 15, 2023
spydon
spydon approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I completely missed this PR! Feel free to ping me if it happens again 😅
Can you fix the small formatting issue so that the pipeline becomes green?

@renancaraujo
Copy link
Member

I think even main build CI is red. LGTM.

@spydon
Copy link
Member

spydon commented Oct 30, 2023

I think even main build CI is red. LGTM.

Fixed!

@spydon spydon merged commit 52c8cfb into bluefireteam:main Oct 30, 2023
3 checks passed
@bdlukaa bdlukaa deleted the enum-constructor branch October 30, 2023 15:02
@spydon
Copy link
Member

spydon commented Oct 30, 2023

@bdlukaa your changes are now released in 0.3.0, sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@renancaraujo renancaraujo renancaraujo approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@luanpotter luanpotter Awaiting requested review from luanpotter

@st-pasha st-pasha Awaiting requested review from st-pasha

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when reaches a constructor on an enum
3 participants
@bdlukaa @renancaraujo @spydon