Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added metrics for system vdom resources #262

Closed
wants to merge 3 commits into from

Conversation

xerox81
Copy link
Contributor

@xerox81 xerox81 commented Dec 14, 2023

Added vdom global resources metrics.

@bluecmd

Copy link
Owner

@bluecmd bluecmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your submission. I've added a comment around the metric structure.

pkg/probe/system_vdom_resources.go Outdated Show resolved Hide resolved
@xerox81
Copy link
Contributor Author

xerox81 commented Jan 31, 2024

I have reduced the metric to only send session usage in percent per vdom because that is the only value I really needed. The metrics structure is better aligned with best practices.

@lazyb0nes
Copy link

@bluecmd

@xerox81 xerox81 requested a review from bluecmd February 9, 2024 18:32
@xerox81 xerox81 closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants