Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distro support for 3.1.8 #719

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix setting SIG_IGN handler for SIGCHLD, SIGPIPE
Caught thanks to Ubuntu 24.10 giving compilation error:

ccache gcc -std=c99 -Wall -g3 -ggdb -O3 -isystem /build/source/stage/include -iquote /build/source/lib -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -I /usr/include/opencv4 -pthread -MMD -DV3_LICENSING -I//build/source/server/lexapi -DBC_VERSION='"3.1.8"' -Wdate-time -D_FORTIFY_SOURCE=3  -c -o signals.o signals.c
signals.c: In function 'signals_setup':
signals.c:61:25: error: assignment to 'void (*)(int,  siginfo_t *, void *)' from incompatible pointer type 'void (*)(int)' [-Wincompatible-pointer-types]
   61 |         sa.sa_sigaction = SIG_IGN;
      |                         ^
make[2]: *** [<builtin>: signals.o] Error 1
andrey-utkin committed Dec 12, 2024
commit 4c7694fc58abbb5a2f89cc54b427c146345f436c
4 changes: 3 additions & 1 deletion server/signals.c
Original file line number Diff line number Diff line change
@@ -58,7 +58,9 @@ void signals_setup()
}

// these signals are ignored:
sa.sa_sigaction = SIG_IGN;
memset(&sa, 0, sizeof(sa));
sa.sa_flags = SA_NOCLDWAIT;
sa.sa_handler = SIG_IGN;
ret = sigaction(SIGCHLD, &sa, NULL);
assert(!ret);
ret = sigaction(SIGPIPE, &sa, NULL);