Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core ui #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add core ui #6

wants to merge 1 commit into from

Conversation

Ceda
Copy link
Contributor

@Ceda Ceda commented Aug 19, 2018

No description provided.

@import "scss/rtl";

// Custom Properties support for Internet Explorer
@import "scss/ie-custom-properties"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaration should be terminated by a semicolon

@@ -0,0 +1,65 @@
/*!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use // comments everywhere

)
) !default;

$aside-menu-nav-padding-y: .75rem !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.75 should be written with a leading zero as 0.75

$sidebar-minimizer-borders: 0 !default;
$sidebar-minimizer-indicator-color: $gray-600 !default;
$sidebar-minimizer-indicator: str-replace(url("data:image/svg+xml;charset=utf8,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 11 14'%3E%3Cpath fill='#{$sidebar-minimizer-indicator-color}' d='M9.148 2.352l-4.148 4.148 4.148 4.148q0.148 0.148 0.148 0.352t-0.148 0.352l-1.297 1.297q-0.148 0.148-0.352 0.148t-0.352-0.148l-5.797-5.797q-0.148-0.148-0.148-0.352t0.148-0.352l5.797-5.797q0.148-0.148 0.352-0.148t0.352 0.148l1.297 1.297q0.148 0.148 0.148 0.352t-0.148 0.352z'/%3E%3C/svg%3E"), "#", "%23") !default;
$sidebar-minimizer-hover-bg: rgba(0,0,0,.3) !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas in function arguments should be followed by one space
.3 should be written with a leading zero as 0.3

// Sidebar Minimizer

$sidebar-minimizer-height: 50px !default;
$sidebar-minimizer-bg: rgba(0,0,0,.2) !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas in function arguments should be followed by one space
.2 should be written with a leading zero as 0.2


$sidebar-footer-height: auto !default;
$sidebar-footer-bg: rgba(0,0,0,.2) !default;
$sidebar-footer-padding-y: .75rem !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.75 should be written with a leading zero as 0.75

// Sidebar Footer

$sidebar-footer-height: auto !default;
$sidebar-footer-bg: rgba(0,0,0,.2) !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas in function arguments should be followed by one space
.2 should be written with a leading zero as 0.2

$sidebar-nav-link-active-borders: 0 !default;

$sidebar-nav-dropdown-color: #fff !default;
$sidebar-nav-dropdown-bg: rgba(0,0,0,.2) !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas in function arguments should be followed by one space
.2 should be written with a leading zero as 0.2

$sidebar-nav-title-padding-y: .75rem !default;
$sidebar-nav-title-padding-x: 1rem !default;
$sidebar-nav-title-color: $gray-200 !default;
$sidebar-nav-link-padding-y: .75rem !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.75 should be written with a leading zero as 0.75

// Sidebar Navigation

$sidebar-nav-color: #fff !default;
$sidebar-nav-title-padding-y: .75rem !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.75 should be written with a leading zero as 0.75

$sidebar-form-border: 0 !default;
$sidebar-form-bg: darken($sidebar-bg,10%) !default;
$sidebar-form-color: #fff !default;
$sidebar-form-placeholder-color: rgba(255,255,255,.7) !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas in function arguments should be followed by one space
.7 should be written with a leading zero as 0.7

// Sidebar Form

$sidebar-form-border: 0 !default;
$sidebar-form-bg: darken($sidebar-bg,10%) !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas in function arguments should be followed by one space


$sidebar-header-height: auto !default;
$sidebar-header-bg: rgba(0,0,0,.2) !default;
$sidebar-header-padding-y: .75rem !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.75 should be written with a leading zero as 0.75

// Sidebar Header

$sidebar-header-height: auto !default;
$sidebar-header-bg: rgba(0,0,0,.2) !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas in function arguments should be followed by one space
.2 should be written with a leading zero as 0.2


// stylelint-disable
$enable-sidebar-nav-rounded: false !default;
$layout-transition-speed: .25s !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.25 should be written with a leading zero as 0.25

@@ -1,3 +1,3 @@
module BlueberryAdmin
VERSION = '0.1.1.9'
VERSION = '0.2'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Freeze mutable objects assigned to constants.

@Ceda Ceda requested a review from milianriedel August 20, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants