-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for admin #4
base: master
Are you sure you want to change the base?
Conversation
end | ||
|
||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra empty line detected at module body end.
encoder | ||
|
||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra empty line detected at class body end.
end | ||
|
||
encoder | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra empty line detected at method body end.
|
||
end | ||
|
||
if match = scan(/\n/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assignment in condition - you probably meant to use ==.
end | ||
|
||
elsif match = scan(/.+/) | ||
@html_scanner.tokenize match, :tokens => encoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the new Ruby 1.9 hash syntax.
@html_scanner.tokenize self[2], :tokens => encoder if self[2] | ||
end | ||
|
||
elsif match = scan(/.+/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assignment in condition - you probably meant to use ==.
elsif match = scan(/((?:<|><?)(?![!?\/\w]))?(.+)?/) | ||
encoder.text_token self[1], :plain if self[1] | ||
# TODO: recognize #{...} snippets | ||
@html_scanner.tokenize self[2], :tokens => encoder if self[2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid more than 3 levels of block nesting.
Use the new Ruby 1.9 hash syntax.
end | ||
end | ||
elsif match = scan(/((?:<|><?)(?![!?\/\w]))?(.+)?/) | ||
encoder.text_token self[1], :plain if self[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid more than 3 levels of block nesting.
@ruby_scanner.tokenize self[4], :tokens => encoder | ||
end | ||
end | ||
elsif match = scan(/((?:<|><?)(?![!?\/\w]))?(.+)?/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assignment in condition - you probably meant to use ==.
Use %r around regular expression.
if self[2] | ||
@embedded_ruby_scanner.tokenize self[4], :tokens => encoder | ||
else | ||
@ruby_scanner.tokenize self[4], :tokens => encoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the new Ruby 1.9 hash syntax.
encoder.text_token self[1] + self[3], :plain | ||
if self[4] | ||
if self[2] | ||
@embedded_ruby_scanner.tokenize self[4], :tokens => encoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the new Ruby 1.9 hash syntax.
|
||
if scan(/(>?<?[-=]|[&!]=|(& |!)|~)( *)([^,\n\|]+(?:(, *|\|(?=.|\n.*\|$))\n?[^,\n\|]*)*)?/) | ||
encoder.text_token self[1] + self[3], :plain | ||
if self[4] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid more than 3 levels of block nesting.
encoder.text_token match, :tag | ||
end | ||
|
||
if scan(/(>?<?[-=]|[&!]=|(& |!)|~)( *)([^,\n\|]+(?:(, *|\|(?=.|\n.*\|$))\n?[^,\n\|]*)*)?/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [100/80]
encoder.text_token self[3], :plain if self[3] | ||
end | ||
|
||
if tag && match = scan(/\//) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assignment in condition - you probably meant to use ==.
Use %r around regular expression.
if tag && match = scan(/(\[)([^\]\n]+)?(\])?/) | ||
encoder.text_token self[1], :plain | ||
@ruby_scanner.tokenize self[2], :tokens => encoder if self[2] | ||
encoder.text_token self[3], :plain if self[3] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid more than 3 levels of block nesting.
|
||
if tag && match = scan(/(\[)([^\]\n]+)?(\])?/) | ||
encoder.text_token self[1], :plain | ||
@ruby_scanner.tokenize self[2], :tokens => encoder if self[2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid more than 3 levels of block nesting.
Use the new Ruby 1.9 hash syntax.
encoder.text_token match, :plain if match | ||
end | ||
|
||
if tag && match = scan(/(\[)([^\]\n]+)?(\])?/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assignment in condition - you probably meant to use ==.
end | ||
@ruby_scanner.tokenize code, :tokens => encoder unless code.empty? | ||
|
||
encoder.text_token match, :plain if match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid more than 3 levels of block nesting.
break | ||
end | ||
end | ||
@ruby_scanner.tokenize code, :tokens => encoder unless code.empty? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid more than 3 levels of block nesting.
Use the new Ruby 1.9 hash syntax.
else | ||
break | ||
end | ||
when "\n", ",", nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
27517c5
to
8a3b851
Compare
class ApplicationController < ActionController::Base | ||
layout 'playground' | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra blank line detected.
Extra empty line detected at class body end.
require_relative '../../../lib/blueberry_admin/coderay_slim.rb' | ||
|
||
module BlueberryAdmin | ||
class ApplicationController < ActionController::Base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing top-level class documentation comment.
@@ -0,0 +1,9 @@ | |||
require_relative '../../../lib/blueberry_admin/coderay_slim.rb' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing frozen string literal comment.
8a3b851
to
e065120
Compare
No description provided.