tests: migrate revme benchmarks to Criterion

[JacekGlen]

This PR migrates the existing revme evm --bench tool to Criterion. The benefits of doing so include:

• more stable results
• detailed reports
• automatic performance degradation detection

The main motivation for this change is that the tool can be used in gas-cost-estimator project, but its purpose goes beyond it. You can learn more about the project from this short presentation, or visit the wiki Stage 4 Scope.

In the future, I'll extend the tool to run on a preloaded state, which is useful for testing scenarios with opcodes like DELEGATECALL or SLOAD.

[rakita]

There is already a cli that allows you to run bytecode in revme: https://github.com/bluealloy/revm/blob/b3f31fc6f2fa0c15f7287ac83ba608a8513ffef1/bins/revme/src/cmd.rs#L21C5-L21C25

and even has a --bench flag.

revm/bins/revme/src/cmd/evmrunner.rs

Lines 94 to 103 in b3f31fc

	if self.bench {
	// Microbenchmark
	let bench_options = microbench::Options::default().time(Duration::from_secs(3));
	microbench::bench(&bench_options, "Run bytecode", || {
	let _ = evm.transact().unwrap();
	});
	return Ok(());
	}

[rakita]

Wouldn't mind replacing it with criterion

[JacekGlen]

There is already a cli that allows you to run bytecode in revme: https://github.com/bluealloy/revm/blob/b3f31fc6f2fa0c15f7287ac83ba608a8513ffef1/bins/revme/src/cmd.rs#L21C5-L21C25

and even has a --bench flag.

revm/bins/revme/src/cmd/evmrunner.rs

Lines 94 to 103 in b3f31fc

	if self.bench {
	// Microbenchmark
	let bench_options = microbench::Options::default().time(Duration::from_secs(3));
	microbench::bench(&bench_options, "Run bytecode", || {
	let _ = evm.transact().unwrap();
	});
	return Ok(());
	}

I missed that, this is cool!

I'll update my PR to use criterion in revme, as suggested. This gives much more stable results.

[JacekGlen]

Wouldn't mind replacing it with criterion

Hi @rakita , I've updates the existing revme benchmark with Criterion. Have a look at the change now, please.

[rakita]

Suggested change

	let evm = Evm::builder()
	.with_db(BenchmarkDB::new_bytecode(Bytecode::new()))
	.modify_tx_env(|tx| {
	tx.caller = address!("1000000000000000000000000000000000000000");
	tx.transact_to = TxKind::Call(address!("0000000000000000000000000000000000000000"));
	})
	.build();
	let host = DummyHost::new(*evm.context.evm.env.clone());
	let mut env = Env::default();
	env.tx.caller = address!("1000000000000000000000000000000000000000");
	env.tx.transact_to = TxKind::Call(address!("0000000000000000000000000000000000000000"));
	let host = DummyHost::new(env);

Dont need builder here.

[rakita]

Suggested change

	EMPTY_SHARED_MEMORY,
	SharedMemory::new();

Shared memory is preallocated and shared between multiple calls, so having SharedMemory::new() will have an initialization hit but it will be slightly faster on memory expansion.

[rakita]

left few nits. lgtm otherwise

[rakita]

lgtm