breeze: context menu looks/feels like "old xfce"

[star-buck]

i am no designer, so i dont know what it makes it that way, but it certainly doesnt look/give a modern feeling, quite the opposite.
Maybe spacing, text and general alignment, could be compared to modern Windows10 or MacOS or Chrome os:

Above is breez dark, but breeze white is equally old look.

[star-buck]

look at that spacing:

beginning of X...

[star-buck]

win10:

[Sodivad]

Windows 10 is the same concept as ours with a bit more spacing and always reserving some space to the left even when the submenu has no icons it looks like

[zzag]

always reserving some space to the left even when the submenu has no icons it looks like

For what it's worth, I made a patch to do the same thing in Breeze a couple of years ago. To me, the lack of space on left side feels awkward and a bit unnatural, I don't know why, it just feels that way... Anyway, that patch was negatively received.

[star-buck]

I think its about the spacing too and recall numerous comments that KDE "doesnt get it" right

…

On Jul 24, 2020 08:49, "Vlad Zahorodnii" ***@***.***> wrote: always reserving some space to the left even when the submenu has no icons it looks like For what it's worth, I made a patch to do the same thing in Breeze a couple of years ago. To me, the lack of space on left side feels awkward and a bit unnatural, I don't know why, it just feels that way... Anyway, that patch was negatively received. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#235 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGNDBS6GWNTXIWLPSXIMKLR5EVH7ANCNFSM4PF6C2JA> .

[Manueljlin]

[star-buck]

Please suggest upstream ticket, the currebt looks absolutely crammed if you just look at top and bottom entries...

…

On Jul 24, 2020 14:23, "Manueljlin" ***@***.***> wrote: [image: Context Menu] <https://user-images.githubusercontent.com/11275573/88390748-2add2000-cdb9-11ea-8e2c-d91f86f9de10.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#235 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGNDBUXCCRQ3HGC25TRT5TR5F4LVANCNFSM4PF6C2JA> .

[Pointedstick]

CCing @noahadvs as well, as he actually has a WIP patch to fix this I think!

[Manueljlin]

Yes, he has a patch for the new highlight style (looks great :D)
I'll post the padding measurements I used soon

[Manueljlin]

I'm back! I was afk for a while, sorry. Here's the measurements.

While here I'm using 10px of padding at the left side, it can use 12px just fine if that's easier and cleaner to code (same goes for the vertical 7 pixels, I just wanted to make the size match the buttons size but if that doesn't matter we can use 8px just fine). The click/touch area is the same as most tabs and buttons (30px) which is probably the bare minimum at making it touch friendly.

I've also used the view color instead of the mix of view background and application background to make the hierarchy a bit clearer.
Will make a phab task soon.

[Manueljlin]

Please suggest upstream ticket, the current looks absolutely crammed if you just look at top and bottom entries...

done @ https://phabricator.kde.org/T13442