calamares: shows to erase all disk and use for OS, but shouldnt it show boot partition?

[star-buck]

when erasing all disk that it does not show the small partition at the beginning it is going to install due to gpt and uefi, but instead shows all is one partition only, which would also contradict its own advise for manual installation:

[adriaandegroot]

You have a BIOS system, so Calamares should not be trying to create an EFI partition on it. If it does, that's a bug (in which case there are two: (1) creating a EFI partition when it shouldn't (2) not showing the EFI partition in the preview).

You are right about the message being contradictory with what Calamares is showing in the preview -- but I think that is because the message is shown inappropriately. I'm pretty sure there's an upstream bug report on that, but have not been able to find it (maybe someone mentioned it on IRC rather than filing a bug).

[star-buck]

Lets try to find the bug(report) and fix it. I think that explains why when it tried to do an efi install the first time, it completely failed at the end and left an unusuable system. So (u)efi still seems a major problem (this is a x1 thinkkpad, secure boot disabled, so nothing fancy). Fixing uefi and showing correct bios installs should be number one priority for calamares.

…

On Jul 24, 2020 14:53, "Adriaan de Groot" ***@***.***> wrote: You have a BIOS system, so Calamares should *not* be trying to create an EFI partition on it. If it does, that's a bug (in which case there are two: (1) creating a EFI partition when it shouldn't (2) not showing the EFI partition in the preview). You are right about the message being contradictory with what Calamares is showing in the preview -- but I think that is because the message is shown inappropriately. I'm pretty sure there's an upstream bug report on that, but have not been able to find it (maybe someone mentioned it on IRC rather than filing a bug). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#230 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGNDBSYOVELZRF47QZX35DR5F74TANCNFSM4PFWJPPA> .

[adriaandegroot]

I have re-filed this upstream as calamares/calamares#1470

[adriaandegroot]

This confusing message has been removed from the partitioning screen and the upstream issue closed. I'm not really happy with it, because as KaOS points out the message prevents problems beforehand (it's patched in to the KaOS Calamares packages) -- now the user is warned afterwards, like it used to be.

I think this one can be closed (once a new-enough Calamares arrives; note that the 3.2.28 series isn't stable yet)