Add studio support #739
Add studio support #739
Conversation
|
+rep |
|
Overall LGTM, but I feel like Studio and Player should be separated into their own "instances", I don't think it's the greatest idea to have both share the same settings, but that's out of the scope for this PR. |
Yeah as there are flags for player that make studio not launch |
|
i support ! |
|
lol is that C++? Wait are you binding that with Python?! Imagine using those over Rust. As a proud Rustacean and Ferris the Crab adorer, I regret to inform you that your taste in languages sucks. This is sad. You can do better. You know how easy package and dependancy management is with Cargo? Not to mention you don’t even need a Makefile. It’s great. Dynamically typed languages need to die. There’s no other option. They just do. If you like dynamic typing, you need some help. Seriously. By using a dynamically typed and interpreted language (which means its @#*!&!@ slow!!!), you are committing genocide and harming the environment more than gas cars. Rust is fast and uses clean, renewable energy through the magic of being a language compiled with LLVM. Tired of memory bugs? You should be. Shame on you for still having them when Rust exists. Tired of being bad? Time to go to Rust. Tired of being slow because you’re not smart and your friends laugh at you? Rust is quite speedy indeed (all thanks to the big brain of the compiler). Tired of not getting off the normal way? Match statements, loops, and the compiler for Rust give the best orgasms 10/10 (completely legit). Not to mention the superiority you get to feel when you show off your superior Rust code to your inferior “friends” still using some other language. Want to get rid of malware? Rust is safe, therefore malware is noware (also completely legit). You quite honestly will forget about any other language (including English because it’s slow and unsafe). You even get to add the Rust Book and its brothers to your Bible collection alongside the Arch and Gentoo Wikis. All hail Rust. TempleOS pales in religious comparison to the faith of Rustaceans. Graydon Hoare is Jesus. Amen. |
not required for studio to launch
| else if (LaunchArgs[0].StartsWith("roblox-studio:")) | ||
| { | ||
| commandLine = ProtocolHandler.ParseUri(LaunchArgs[0]); | ||
| if (!commandLine.Contains("-startEvent")) | ||
| commandLine += " -startEvent www.roblox.com/robloxQTStudioStartedEvent"; | ||
| isStudioLaunch = true; | ||
| } | ||
| else if (LaunchArgs[0].StartsWith("roblox-studio-auth:")) | ||
| { | ||
| commandLine = HttpUtility.UrlDecode(LaunchArgs[0]); | ||
| isStudioLaunch = true; | ||
| isStudioAuth = true; | ||
| } | ||
| else if (LaunchArgs[0] == "-ide") | ||
| { | ||
| isStudioLaunch = true; | ||
| if (LaunchArgs.Length >= 2) | ||
| commandLine = $"-task EditFile -localPlaceFile \"{LaunchArgs[1]}\""; | ||
| } |
There was a problem hiding this comment.
You can simply pass Studio -protocolString, the same can be said for player by simply providing the launch URI, as player and studio can handle the URI independently!
|
Looks good, provids a great base to work with. |
#36
#516
TODO checklist: