Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chunk loading exception #610

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: chunk loading exception #610

merged 1 commit into from
Sep 6, 2023

Conversation

jeeanribeiro
Copy link
Member

@jeeanribeiro jeeanribeiro commented Sep 6, 2023 •
edited by maxwellmattryan
Loading

Summary

This fixes the chunk exception when the app is compiled

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro self-assigned this Sep 6, 2023
@jeeanribeiro jeeanribeiro linked an issue Sep 6, 2023 that may be closed by this pull request
️🛠 - Fix loading chunk exception on packaged builds #497
Closed
@jeeanribeiro jeeanribeiro changed the title chore: update @bloomwalletio/ui fix: chunk loading exception Sep 6, 2023
maxwellmattryan
maxwellmattryan approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and no errors but also no icons 🤔 🌸

nicole-obrien
nicole-obrien approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons work for me, and tested packaged app on mac without issue

@nicole-obrien nicole-obrien merged commit 123aa93 into develop Sep 6, 2023
9 checks passed
@nicole-obrien nicole-obrien deleted the 497-fix-loading-chunk-exception-on-packaged-builds branch September 6, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicole-obrien nicole-obrien nicole-obrien approved these changes

@maxwellmattryan maxwellmattryan maxwellmattryan approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

Assignees

@jeeanribeiro jeeanribeiro

Labels
scope:dependencies type:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

️🛠 - Fix loading chunk exception on packaged builds
3 participants
@jeeanribeiro @maxwellmattryan @nicole-obrien