Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add gas price polling during send flow #609

Merged
merged 9 commits into from
Sep 6, 2023

Conversation

maxwellmattryan
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

This PR adds polling of gas prices during the send flow to improve UX.

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

nicole-obrien
nicole-obrien previously approved these changes Sep 6, 2023
@nicole-obrien nicole-obrien merged commit c6d289b into develop Sep 6, 2023
4 checks passed
@nicole-obrien nicole-obrien deleted the 540-poll-the-gas-price-during-the-send-flow branch September 6, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

️🛠 - Poll the gas price during the send flow
2 participants