Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: display total transaction fees for L1 - L2 transactions #546

Conversation

nicole-obrien
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

…incorrect-surplus-amount-when-gifting-storage-deposit-on-l1-l2-transaction
…incorrect-surplus-amount-when-gifting-storage-deposit-on-l1-l2-transaction
…incorrect-surplus-amount-when-gifting-storage-deposit-on-l1-l2-transaction
@MarkNerdi MarkNerdi marked this pull request as ready for review September 4, 2023 12:20
…surplus-amount-when-gifting-storage-deposit-on-l1-l2-transaction
@nicole-obrien
Copy link
Contributor Author

Lets look at this together, I think there is still some improvements to be made, and might be cleaner to make a Stardust -> Evm summary page to simplify the logic in the file

Copy link
Contributor

@MarkNerdi MarkNerdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MarkNerdi MarkNerdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi MarkNerdi merged commit 611ba5e into develop Sep 5, 2023
@MarkNerdi MarkNerdi deleted the 499-fix-incorrect-surplus-amount-when-gifting-storage-deposit-on-l1-l2-transaction branch September 5, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

️🛠 - Fix incorrect surplus amount when gifting storage deposit on L1 -> L2 transaction
2 participants