Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: send flow type to enum #532

Merged
merged 22 commits into from
Sep 8, 2023
Merged

chore: send flow type to enum #532

merged 22 commits into from
Sep 8, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Aug 30, 2023 •
edited by maxwellmattryan
Loading

Summary

Addresses TODO of moving SendFlowType into separate file.
Blocked until #519 is merged.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi requested a review from maxwellmattryan August 30, 2023 08:55
@Tuditi Tuditi self-assigned this Aug 30, 2023
@Tuditi Tuditi marked this pull request as ready for review September 1, 2023 11:54
@Tuditi Tuditi marked this pull request as draft September 1, 2023 11:59
@Tuditi Tuditi marked this pull request as ready for review September 1, 2023 11:59
@Tuditi Tuditi marked this pull request as draft September 8, 2023 13:16
@Tuditi Tuditi marked this pull request as ready for review September 8, 2023 13:16
@MarkNerdi MarkNerdi requested review from MarkNerdi and removed request for cvarley100, maxwellmattryan and nicole-obrien September 8, 2023 13:33
@maxwellmattryan maxwellmattryan changed the title Chore: send flow type to enum chore: send flow type to enum Sep 8, 2023
maxwellmattryan
maxwellmattryan approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌸

@maxwellmattryan maxwellmattryan merged commit 3e12b36 into develop Sep 8, 2023
4 checks passed
@maxwellmattryan maxwellmattryan deleted the chore/send-flow-type-to-enum branch September 8, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwellmattryan maxwellmattryan maxwellmattryan approved these changes

@MarkNerdi MarkNerdi Awaiting requested review from MarkNerdi

Assignees

@Tuditi Tuditi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tuditi @maxwellmattryan @MarkNerdi