Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use max gas fee when sending from L1 -> L2 #494

Merged
merged 11 commits into from
Aug 29, 2023
Merged

fix: use max gas fee when sending from L1 -> L2 #494

merged 11 commits into from
Aug 29, 2023

Conversation

nicole-obrien
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@nicole-obrien nicole-obrien self-assigned this Aug 24, 2023
@nicole-obrien nicole-obrien linked an issue Aug 24, 2023 that may be closed by this pull request
️🛠 - Use max gas fee in amount of L2 transactions rather than estimatedGasFee #472
Closed
@nicole-obrien
Merge branch 'develop' into 472-use-max-gas-fee-in-amount-of-l2-trans…
bf6b172 
…actions-rather-than-estimatedgasfee
@nicole-obrien
Merge remote-tracking branch 'origin/develop' into 472-use-max-gas-fe…
6b42fdb 
…e-in-amount-of-l2-transactions-rather-than-estimatedgasfee
maxwellmattryan
maxwellmattryan previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌸

maxwellmattryan and others added 2 commits August 24, 2023 21:42
@maxwellmattryan
Merge branch 'develop' into 472-use-max-gas-fee-in-amount-of-l2-trans…
ea91842 
…actions-rather-than-estimatedgasfee
@nicole-obrien
495 better estimate l1 l2 gas fee instead of constant fallback (#502)
1148abb 
* enhancement: improve fall back estimate gas

* fix tests

* fix: make tests more accurate
maxwellmattryan
maxwellmattryan previously requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some changes requested 🙏

packages/desktop/views/dashboard/send-flow/views/components/StardustTransactionSummary.svelte Outdated Show resolved Hide resolved
packages/shared/src/lib/core/layer-2/constants/fallback-estimated-gas.constant.ts Show resolved Hide resolved
packages/shared/src/lib/core/layer-2/utils/estimateGasForLayer1ToLayer2Transaction.ts Show resolved Hide resolved
packages/shared/src/lib/core/layer-2/utils/estimateGasForLayer1ToLayer2Transaction.ts Outdated Show resolved Hide resolved
packages/shared/src/lib/core/layer-2/utils/estimateGasForLayer1ToLayer2Transaction.ts Outdated Show resolved Hide resolved
packages/shared/src/lib/core/layer-2/utils/estimateGasForLayer1ToLayer2Transaction.ts Outdated Show resolved Hide resolved
packages/shared/src/lib/core/layer-2/utils/estimateGasForLayer1ToLayer2Transaction.ts Outdated Show resolved Hide resolved
packages/shared/src/lib/core/layer-2/utils/estimateGasForLayer1ToLayer2Transaction.ts Outdated Show resolved Hide resolved
packages/shared/src/lib/core/wallet/utils/getOutputParameters.ts Outdated Show resolved Hide resolved
Tuditi
Tuditi previously approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi requested a review from maxwellmattryan August 29, 2023 09:09
@nicole-obrien nicole-obrien merged commit ce8e44f into develop Aug 29, 2023
@nicole-obrien nicole-obrien deleted the 472-use-max-gas-fee-in-amount-of-l2-transactions-rather-than-estimatedgasfee branch August 29, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@maxwellmattryan maxwellmattryan Awaiting requested review from maxwellmattryan

Assignees

@nicole-obrien nicole-obrien

Labels
type:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

️🛠 - Use max gas fee in amount of L2 transactions rather than estimatedGasFee
3 participants
@nicole-obrien @maxwellmattryan @Tuditi