Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create activity from evm transaction #467

Merged
merged 8 commits into from
Aug 30, 2023

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi self-assigned this Aug 22, 2023
@MarkNerdi MarkNerdi linked an issue Aug 22, 2023 that may be closed by this pull request
2 tasks
@MarkNerdi MarkNerdi force-pushed the 349-generate-activity-from-transactions branch from 2d5987b to 74062b1 Compare August 23, 2023 10:10
@MarkNerdi MarkNerdi force-pushed the 349-generate-activity-from-transactions branch from 74062b1 to c74852e Compare August 25, 2023 13:32
@MarkNerdi MarkNerdi marked this pull request as ready for review August 25, 2023 14:31
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and app is functioning well - one piece of feedback is that the wallet / contact name isn't used in the activities with EVM addresses; small improvement but a worthy one IMO

@nicole-obrien nicole-obrien merged commit 476bceb into develop Aug 30, 2023
4 checks passed
@nicole-obrien nicole-obrien deleted the 349-generate-activity-from-transactions branch August 30, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

️🛠 - Generate Activity from transactions
3 participants