-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create activity from evm transaction #467
Merged
nicole-obrien
merged 8 commits into
develop
from
349-generate-activity-from-transactions
Aug 30, 2023
Merged
feat: create activity from evm transaction #467
nicole-obrien
merged 8 commits into
develop
from
349-generate-activity-from-transactions
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MarkNerdi
force-pushed
the
349-generate-activity-from-transactions
branch
from
August 23, 2023 10:10
2d5987b
to
74062b1
Compare
MarkNerdi
force-pushed
the
349-generate-activity-from-transactions
branch
from
August 25, 2023 13:32
74062b1
to
c74852e
Compare
maxwellmattryan
previously requested changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and app is functioning well - one piece of feedback is that the wallet / contact name isn't used in the activities with EVM addresses; small improvement but a worthy one IMO
…rate-activity-from-transactions
…rate-activity-from-transactions
Co-authored-by: MarkNerdi996 <[email protected]>
nicole-obrien
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...
Testing
Platforms
Instructions
...
Checklist