Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit number of account network summary based on screen size #2845

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix: limit number of account network summary based on screen size #2845

merged 2 commits into from
Sep 26, 2024

Conversation

jeeanribeiro
Copy link
Member

Summary

closes #2833

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro self-assigned this Sep 26, 2024
@jeeanribeiro jeeanribeiro linked an issue Sep 26, 2024 that may be closed by this pull request
️🛠 - Don't show all networks on the dashboard #2833
Closed
@jeeanribeiro jeeanribeiro force-pushed the 2833----dont-show-all-networks-on-the-dashboard branch from e74bf3e to be0580e Compare September 26, 2024 13:11
@nicole-obrien nicole-obrien enabled auto-merge (squash) September 26, 2024 14:26
@nicole-obrien nicole-obrien merged commit 56327ef into develop Sep 26, 2024
7 checks passed
@nicole-obrien nicole-obrien deleted the 2833----dont-show-all-networks-on-the-dashboard branch September 26, 2024 14:28
jeeanribeiro added a commit that referenced this pull request Oct 11, 2024
@jeeanribeiro @nicole-obrien
fix: limit number of account network summary based on screen size (#2845
2649691 
)

Co-authored-by: Nicole O'Brien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicole-obrien nicole-obrien nicole-obrien approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

Assignees

@jeeanribeiro jeeanribeiro

Labels
type:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

️🛠 - Don't show all networks on the dashboard
2 participants
@jeeanribeiro @nicole-obrien