Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add warning on recipient input screen when sending l1 to a layer 2 address #2556

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi self-assigned this May 28, 2024
@MarkNerdi MarkNerdi removed the request for review from cvarley100 May 28, 2024 14:01
Copy link
Member

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

We could also add step-by-step later in our docs for recovering IRC assets that were sent to MetaMask

@jeeanribeiro jeeanribeiro enabled auto-merge (squash) May 29, 2024 00:29
@jeeanribeiro jeeanribeiro merged commit 5cbca17 into develop May 29, 2024
7 checks passed
@jeeanribeiro jeeanribeiro deleted the 2536----add-warning-on-recipient-input-screen-when-sending-l1-to-a-layer-2-address branch May 29, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

️🛠 - Add warning on recipient input screen when sending L1 to a layer 2 address
2 participants