Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hidden/scam nfts in collections #2546

Merged
merged 1 commit into from
May 27, 2024
+9 −8
Merged

fix: remove hidden/scam nfts in collections #2546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/desktop/views/dashboard/collectibles/components/CollectionDetails.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

export let collectionId: string

$: nfts = $ownedNfts.filter((nft) => nft.collectionId === collectionId)
$: nfts = $ownedNfts.filter((nft) => nft.collectionId === collectionId && !nft.hidden && !nft.isScam)

onDestroy(() => {
$selectedCollectionId = undefined
Expand Down
2 changes: 1 addition & 1 deletion packages/desktop/views/dashboard/collectibles/components/CollectionsGalleryItem.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}

$: collection = $persistedCollections[collectionId]
$: nfts = $ownedNfts.filter((nft) => nft.collectionId === collectionId)
$: nfts = $ownedNfts.filter((nft) => nft.collectionId === collectionId && !nft.hidden && !nft.isScam)
</script>

{#if collection && nfts.length > 0}
Expand Down
13 changes: 7 additions & 6 deletions packages/desktop/views/dashboard/collectibles/views/CollectionsGalleryView.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,18 @@

let queriedCollectionsIds: string[] = []

$: collectionsIds = new Set(
$ownedNfts
?.map((nft) => nft.collectionId)
.filter((collectionId) => collectionId && $persistedCollections[collectionId])
)
$: collectionsIds = $ownedNfts?.reduce((set, nft) => {
if (!nft.hidden && !nft.isScam && nft.collectionId && $persistedCollections[nft.collectionId]) {
set.add(nft.collectionId)
}
return set
}, new Set<string>())

$: $collectionsSearchTerm, collectionsIds, setQueriedCollectionsIds()

function setQueriedCollectionsIds(): void {
queriedCollectionsIds = Array.from(collectionsIds)
.filter((collectionId) => isVisibleCollection($persistedCollections[collectionId]))
?.filter((collectionId) => isVisibleCollection($persistedCollections[collectionId]))
.sort((collectionId1, collectionId2) =>
$persistedCollections[collectionId1]?.name
.toLowerCase()
Expand Down
Loading