Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add approval popup #2529

Merged
merged 11 commits into from
May 23, 2024
Merged

feat: add approval popup #2529

merged 11 commits into from
May 23, 2024

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi self-assigned this May 22, 2024
@MarkNerdi MarkNerdi removed the request for review from cvarley100 May 22, 2024 13:15
@MarkNerdi MarkNerdi linked an issue May 22, 2024 that may be closed by this pull request
3 tasks
@nicole-obrien nicole-obrien enabled auto-merge (squash) May 23, 2024 10:18
@nicole-obrien nicole-obrien merged commit 7ebfe4b into develop May 23, 2024
7 checks passed
@nicole-obrien nicole-obrien deleted the feat/add-approval-popup branch May 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse ERC20 token approvals and show data on sign transaction popup
2 participants