Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notification components #2514

Merged
merged 8 commits into from
May 21, 2024

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi removed the request for review from cvarley100 May 19, 2024 14:53
@MarkNerdi MarkNerdi changed the base branch from develop to feature/notifications May 19, 2024 14:53
@jeeanribeiro
Copy link
Member

jeeanribeiro commented May 20, 2024

I wasn't able to test it, notifications in https://gm.walletconnect.com/ are simply not working for me :(

Error: getNotificationHistory timed out waiting for a response
    at index.es.js:14:1
index.ts:29 Error: No matching key. keychain: 89d701ffb56bc3050e8c23703de20ed7a283473e37604147c6ae277d2a1ddf9e
    at xt.get (index.es.js:1:1)
    at Ot.getSymKey (index.es.js:1:1)
    at Ot.encode (index.es.js:1:1)
    at Zt.sendRequest (index.es.js:14:1)
    at index.es.js:14:1
    at new Promise (<anonymous>)
    at Zt.getNotificationHistory (index.es.js:14:1)
{time: 1716237553100, level: 50, context: 'core/crypto', msg: "Failed to decode message from topic: '90f1573366dd…z6MkwUm3sEoPwQzmSHCqv5jpLRDZZD9MTAuWZczuWrpEJe4X'"}
context
: 
"core/crypto"
level
: 
50
msg
: 
"Failed to decode message from topic: '90f1573366dd70834c7ede6e7fde6ece446c4b1788c3bc98f6b6e6d76272db5a', clientId: 'did:key:z6MkwUm3sEoPwQzmSHCqv5jpLRDZZD9MTAuWZczuWrpEJe4X'"
time
: 
1716237553100

@MarkNerdi
Copy link
Contributor Author

@jeeanribeiro
This error is thrown somewhere in the library, I reached out to the WalletConnect team for help. Meanwhile you can delete the database in the Application tab to reset your local notifyClient

@MarkNerdi MarkNerdi force-pushed the feat/add-notification-components branch from 80edacb to f50c00f Compare May 21, 2024 13:10
@MarkNerdi MarkNerdi merged commit 731e53a into feature/notifications May 21, 2024
3 of 5 checks passed
@MarkNerdi MarkNerdi deleted the feat/add-notification-components branch May 21, 2024 14:25
nicole-obrien added a commit that referenced this pull request Jun 12, 2024
* feat: add walletconnect notify api (#2512)

* initialize notify client

* notify client store

* register and subscribe to notifications

* implement test subscription

* improve initialization

* subscribe to gm walletconnect

* create notify manager class

Co-authored-by: Nicole O'Brien <[email protected]>
Co-authored-by: Tuditi <[email protected]>

* set notifications to store

* update yarn lock

* initialize notifications and subscriptions

Co-authored-by: Tuditi <[email protected]>
Co-authored-by: Nicole O'Brien <[email protected]>

* cleanup handlers

Co-authored-by: Tuditi <[email protected]>
Co-authored-by: Nicole O'Brien <[email protected]>
Co-authored-by: Jean Ribeiro <[email protected]>

---------

Co-authored-by: Nicole O'Brien <[email protected]>
Co-authored-by: Tuditi <[email protected]>
Co-authored-by: Jean Ribeiro <[email protected]>

* chore: cleanup notification manager init (#2513)

* cleanup notification manager initialization

Co-authored-by: Nicole O'Brien <[email protected]>

* add message handler

---------

Co-authored-by: Nicole O'Brien <[email protected]>

* fix: fix notify client (#2516)

* fix notify client initialize

* fix dependencies

Co-authored-by: Jean Ribeiro <[email protected]>

---------

Co-authored-by: Jean Ribeiro <[email protected]>

* feat: add notification components (#2514)

* WIP

* improve notification popup

* use dapp icon as main image

* add small badge

* add notificationavatar

* only show fixed amount + add localizations

Co-authored-by: Jean Ribeiro <[email protected]>

* add time test

* cleanup

---------

Co-authored-by: Jean Ribeiro <[email protected]>

* feat: adds Link in NotificationTile (#2528)

* feat: highlight unread notifications (#2527)

* chore: refactor for multi chain support (#2511)

* chore: remove BASE_TOKEN_CONTRACT_ADDRESS map

* chore: rename getL1Network to getStardustNetwork

* fix: type

* feat: highlight unread notification

* fix incoming notifications

* restructure

---------

Co-authored-by: Tuditi <[email protected]>
Co-authored-by: Mark Nardi <[email protected]>

* feat: mark notification as read if visible (#2532)

* fix: removes view all button and show all notifications in dropdown

* feat: mark notifications as read if visible

* chore: update @bloomwalletio/ui

* fix: updates notifications store only after closing the dropdown

* decrease threshold

---------

Co-authored-by: Mark Nardi <[email protected]>

* fix: type errors

* feat: notifications unread tab (#2540)

* feat: notifications unread tab

* add optional chain

---------

Co-authored-by: Mark Nardi <[email protected]>

* enhancement: uses VirtualList in notifications (#2541)

* enhancement: uses VirtualList in notifications

* fix merge issue

---------

Co-authored-by: Mark Nardi <[email protected]>

* cleanup

* feat: notification details popup (#2554)

* show basetoken amount on smartcontract popups (#2549)

* feat: adds notification details popup

Co-authored-by: Mark Nardi <[email protected]>
Co-authored-by: Nicole O'Brien <[email protected]>
Co-authored-by: Tuditi <[email protected]>

* fix: PopupComponentMap type

---------

Co-authored-by: Mark Nardi <[email protected]>
Co-authored-by: Nicole O'Brien <[email protected]>
Co-authored-by: Tuditi <[email protected]>

* fix linter

* fix: notification read state

Co-authored-by: Mark Nardi <[email protected]>

* polish nav bar with notification button

* split notification components

* remove notification tabs

* enable notifications for multiple networks

* fix notifications initialization

* improve siwe validation check

* fix: notification tile hover

* fix: popover closing behaviour for notifications

* ui: empty placeholder in notifications

* enable notifications in network drawer

* fix notification toggle state

* improve notification registering

Co-authored-by: Mark Nardi <[email protected]>

* register for notifications on some generate addresses

* register account on evm address generation

* only register if not registered

* fix login if account is unregistered

* Fix notification registration on onboarding

Co-authored-by: Nicole O'Brien <[email protected]>

* remove mulitple instances of notifiation body

* WIP

* fix: whitelist notification links

* fix tracked address initialization

* remove console logs

* ui: polish notification details popup

Co-authored-by: Mark Nardi <[email protected]>

* ui: polish notification tile

* improve logic in complete onboarding

Co-authored-by: Mark Nardi <[email protected]>

* chore: fix formatting

---------

Co-authored-by: Nicole O'Brien <[email protected]>
Co-authored-by: Tuditi <[email protected]>
Co-authored-by: Jean Ribeiro <[email protected]>
Co-authored-by: Tuditi <[email protected]>
Co-authored-by: Nicole O'Brien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants