Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: fix explorer link for ethereum network #2469

Merged
merged 12 commits into from
May 14, 2024
Merged

enhancement: fix explorer link for ethereum network #2469

merged 12 commits into from
May 14, 2024

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi self-assigned this May 10, 2024
@MarkNerdi MarkNerdi linked an issue May 10, 2024 that may be closed by this pull request
️🛠 - Fix explorer link for Ethereum network #2444
Closed
@Tuditi Tuditi enabled auto-merge (squash) May 14, 2024 08:24
Tuditi
Tuditi previously approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tuditi
Tuditi approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tuditi Tuditi merged commit 44fb8af into develop May 14, 2024
7 checks passed
@Tuditi Tuditi deleted the 2444-fix-explorer-link-for-ethereum-network branch May 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien nicole-obrien is a code owner

Assignees

@MarkNerdi MarkNerdi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

️🛠 - Fix explorer link for Ethereum network
2 participants
@MarkNerdi @Tuditi