Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor evm network type #2402

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Apr 30, 2024

Summary

closes: #2405

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@nicole-obrien nicole-obrien changed the title chore: refactor evm network typ chore: refactor evm network type Apr 30, 2024
@Tuditi Tuditi changed the base branch from develop to 2359-fetch-token-balances-for-evm-chains April 30, 2024 12:27
@nicole-obrien nicole-obrien marked this pull request as ready for review April 30, 2024 13:19
Base automatically changed from 2359-fetch-token-balances-for-evm-chains to develop April 30, 2024 13:37
@Tuditi Tuditi force-pushed the chore/refactor-evm-network-typ branch from 724fb98 to ab53e30 Compare April 30, 2024 14:44
@nicole-obrien nicole-obrien enabled auto-merge (squash) April 30, 2024 15:07
@nicole-obrien nicole-obrien merged commit 4f5d520 into develop Apr 30, 2024
6 checks passed
@nicole-obrien nicole-obrien deleted the chore/refactor-evm-network-typ branch April 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

️🛠 - Add network type to all networks that implement the base network class.
3 participants