Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add evm network recipients #2401

Merged
merged 19 commits into from
May 1, 2024

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Apr 30, 2024

Summary

closes: #2404

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi changed the base branch from develop to chore/refactor-evm-network-typ April 30, 2024 10:07
@Tuditi Tuditi linked an issue Apr 30, 2024 that may be closed by this pull request
@nicole-obrien nicole-obrien marked this pull request as ready for review April 30, 2024 13:19
Base automatically changed from chore/refactor-evm-network-typ to develop April 30, 2024 15:09
Copy link
Contributor Author

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it breaks the flow if accessed through the portfolio tab.

image

nicole-obrien
nicole-obrien previously approved these changes May 1, 2024
@nicole-obrien nicole-obrien merged commit f4ac896 into develop May 1, 2024
6 checks passed
@nicole-obrien nicole-obrien deleted the feat/add-evm-network-recipients branch May 1, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

️🛠 - Implement EVM recipient selectors
3 participants